Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable composer cache #105

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Enable composer cache #105

merged 1 commit into from
Apr 7, 2016

Conversation

goetas
Copy link
Member

@goetas goetas commented Mar 19, 2016

No description provided.

@goetas
Copy link
Member Author

goetas commented Mar 19, 2016

no big differences... maybe 10-15 % of improvements.

Is it worth?

@mattfarina
Copy link
Member

So, I'll get a little technical here because this is interesting.

This is really a shift from crabbing checkouts of projects as a tarball and transferring it between GitHub and Travis CI to a setup where package versions as tarballs are stored locally in Travis (moved around as needed) and only new versions are fetched. The fact they are close in performance is a testament to the performance tuning done by GitHub.

Because GitHub has to regularly checkout a version and perform computation to create the tarballs I'm inclined to use the caching. I suspect caching is, on a combined system scale, lower on computation.

Anyone else have thoughts?

@mattfarina
Copy link
Member

Also, this should be cherry picked to the 2.x branch once merged.

@goetas
Copy link
Member Author

goetas commented Apr 6, 2016

So you look "pro" to this feature, right?

@mattfarina mattfarina merged commit 7951b73 into master Apr 7, 2016
@mattfarina mattfarina deleted the composer-cache branch April 7, 2016 12:43
@mattfarina
Copy link
Member

@goetas Yeah, I'm pro-cache in this case. We can always undo this later pretty easily.

@goetas
Copy link
Member Author

goetas commented Apr 7, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants