Fix PHP Notice in OutputRules #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of DOMCharacterData
|
can you add a test for it? |
|
Sure, have done. Turns out I was slightly wrong in my assumption about the HTML not conforming to spec. I found out that it was manipulation of the DOM that was causing the issue; appending a non-text child node to a Are you sure this should be tagged as an enhancement? I'd call it a bugfix more than anything else. |
|
This issue gets more interesting. Immagine this (a mustache.js template): <html lang="en" id="base">
<body>
<script id="template" type="x-tmpl-mustache">
<h1>Hello {{ name }}!</h1>
</script>
</body>
</html>Adding a <html lang="en" id="base">
<body>
<script id="template" type="x-tmpl-mustache">
<h1>Hello {{ name }}!</h1>
<p>foo</p></script>
</body>
</html>While with your changes will just be ignored |
goetas
added a commit
that referenced
this pull request
Aug 19, 2016
goetas
added a commit
that referenced
this pull request
Aug 19, 2016
goetas
added a commit
that referenced
this pull request
Aug 19, 2016
|
#117 is and alternative solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When outputting a
TEXT_RAWnode, OutputRules will occasionally throw the PHP NoticeUndefined property: DOMElement::$data.This seems to happen when processing HTML that doesn't strictly conform to spec (my test case had child nodes inside an
iframe), however we can prevent the issue by type checking the node before accessing thedataproperty