Respect self-closing tags only on foreign elements #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac514
reviewed
Aug 21, 2018
test/HTML5/Parser/TokenizerTest.php
Outdated
| $this->assertEventEquals('startTag', $expects, $events->get(0)); | ||
| $this->assertEventEquals('endTag', $expects, $events->get(1)); | ||
| $this->assertTrue($events->get(0)['data'][2]); |
There was a problem hiding this comment.
This syntax fails in PHP 5.3
https://travis-ci.org/Masterminds/html5-php/jobs/311341191#L260
Also, any chance this will ever get merged?
|
Dac, Thanks for the review. It's fixed in my latest push, I think. Probably won't be merged as this repo seems pretty unmaintained. --Albert |
|
A stable project with really few bugs should not be defined as "unmaintained" 😃 |
|
Out-of-spec behaviour is not a bug, then? |
|
I'm not saying is it not a bug... just worried about BC breaks. From what I know Drupal guys could have a good test suite to check if this breaks something.. |
|
@xjm Is there anybody in drupal that can test this ? |
|
Tested, google chrome has the same behavior as this proposal. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #136.
See also: https://www.w3.org/TR/html5/syntax.html#start-tags