Add more extensions on composer.json, improve phpdocs and remove dead code #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
commented
Oct 22, 2018
| @@ -136,6 +136,7 @@ class DOMTreeBuilder implements EventHandler | |||
| protected $stack = array(); | |||
|
|
|||
| protected $current; // Pointer in the tag hierarchy. | |||
| protected $rules; | |||
There was a problem hiding this comment.
The property was dynamically set in the constructor.
tgalopin
commented
Oct 22, 2018
| @@ -126,7 +131,7 @@ public function currentLine() | |||
| */ | |||
| public function getCurrentLine() | |||
| { | |||
| return currentLine(); | |||
| return $this->currentLine(); | |||
There was a problem hiding this comment.
I think this was a bug.
tgalopin
force-pushed
the
phpdoc-improvements
branch
4 times, most recently
from
579445c
to
8bcaeec
Compare
goetas
reviewed
Oct 23, 2018
composer.json
Outdated
| "ext-dom": "*", | ||
| "ext-iconv": "*", |
There was a problem hiding this comment.
iconv is used only as fallback when mbstring is not present, so technically both iconv and mbstring are optional (but at least one of them is required)
Any idea on how to express this in composer?
There was a problem hiding this comment.
You are right, I don't think there is any way to ask Composer for that. Let's keep an exception :) .
tgalopin
force-pushed
the
phpdoc-improvements
branch
from
8bcaeec
to
80b8e91
Compare
|
Updated :) |
|
Thanks! |
|
No problem, I didn't update it before anyway :) . Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a few things:
Don't hesitate to answer my comments when you think I'm wrong :) !