Optimize the handling of references when consuming data #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method call to
characterReference
in allconsumeData
calls is costly.Inlining it is quite easy, and allows avoiding reading twice the current token when there is no reference at this point.
Here is the effect on the benchmark included in this repo.
Before:
Loading: 127.32289552689
Writing: 37.346167564392
After:
Loading: 115.40209054947
Writing: 37.080278396606
That's a 9% improvement on the loading time.