Optimize the token comparison #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently looking at better optimizations for these places, so I'm closing this PR for now. |
stof
force-pushed
the
optimize_token_comparison
branch
from
46559df
to
66ee892
Compare
|
OK, reopening without the change in unquoted attributes (to avoid the conflicts with #155). The numbers still apply, as this benchmark was not using unquoted attributes. |
|
because of recent CS changes, this requires to be rebased |
stof
force-pushed
the
optimize_token_comparison
branch
from
66ee892
to
541f2b7
Compare
|
@goetas done |
|
cs failure |
Tokens are always a single char. Using strspn to find whether they belong to a fixed list is slower than comparing them directly.
stof
force-pushed
the
optimize_token_comparison
branch
from
541f2b7
to
89e1a7a
Compare
|
Updated |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens are always a single char. Using strspn to find whether they belong to a fixed list is slower than comparing them directly.
Loading benchmark:
Before: 113.15485715866
After: 112.65460729599
That's not a huge difference, but it still helps.