Improve Travis configuration and add PHP-CS-Fixer #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
force-pushed
the
coding-style
branch
from
8d7e1fc
to
96ec9d9
Compare
tgalopin
force-pushed
the
coding-style
branch
6 times, most recently
from
9e92b70
to
007f9a3
Compare
goetas
reviewed
Nov 25, 2018
| */ | ||
| public static function lookupDecimal($int) | ||
| { | ||
| $entity = '&#' . $int . ';'; | ||
| $entity = '&#'.$int.';'; |
There was a problem hiding this comment.
arent spaces enforced when concatenating variables?
goetas
reviewed
Nov 25, 2018
src/HTML5/Parser/Scanner.php
Outdated
| @@ -284,12 +285,12 @@ public function charsWhile($mask) | |||
| * | |||
| * Newlines are column 0. The first char after a newline is column 1. | |||
| * | |||
| * @return int The column number. | |||
| * @return int the column number | |||
There was a problem hiding this comment.
is there some rule that enforces the first letter lowercase?
goetas
reviewed
Nov 25, 2018
|
What about adding a <?php
$finder = PhpCsFixer\Finder::create()
->in(__DIR__)
;
return PhpCsFixer\Config::create()
->setRules([
'@Symfony' => true,
'concat_space' => ['spacing' => 'one'],
])
->setFinder($finder)
;As a personal preference (and less changes to the current codebase), I suggest |
tgalopin
force-pushed
the
coding-style
branch
from
007f9a3
to
d829a30
Compare
tgalopin
force-pushed
the
coding-style
branch
from
6d7839a
to
91e7977
Compare
|
Updated :) . |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.