Add special case for end tag </br>. Fixes #185 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, an end tag for a void element would simply be discarded, but the spec includes a special rule as follows: > An end tag whose tag name is "br" > Parse error. Drop the attributes from the token, and act as > described in the next entry; i.e. act as if this was a "br" > start tag token with no attributes, rather than the end tag > token that it actually is.
goetas
reviewed
Jun 24, 2020
| if (Elements::isA($name, Elements::VOID_TAG)) { | ||
| // Special case within 12.2.6.4.7: An end tag whose tag name is "br" should be treated as an opening tag | ||
| if ($name === 'br') { | ||
| $this->parseError('Closing tag encountered for void element br.'); |
There was a problem hiding this comment.
I'm not sure that triggering a parse error is needed. Will the returned DOM still be as expected?
There was a problem hiding this comment.
I was just going by the wording of the spec, which has a specific definition of "parse error" in terms of declaring a document non-conformant, even where the result is well-defined.
The DOM should look exactly as though this was a normal void <br> tag with no attributes, so I'm happy to remove this line if you want to limit parseError to more serious problems.
There was a problem hiding this comment.
We already have parse errors for stuff like duplicate IDs, so ...
|
thank you! |
lyrixx
pushed a commit
to lyrixx/html5-php
that referenced
this pull request
Jun 30, 2020
Add special case for end tag </br>. Fixes Masterminds#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, an end tag for a void element would simply be discarded,
but the spec includes a special rule as follows:
closes #185