Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitigate cyclic reference between output rules and the traverser objects #190

Merged
merged 1 commit into from
Jul 3, 2020
Merged

mitigate cyclic reference between output rules and the traverser objects #190

merged 1 commit into from
Jul 3, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Jul 3, 2020 •
edited
Loading

Alternative implementation of #188

it is substantially the same but using a separate method in the concrete class...

closes #188

@goetas goetas mentioned this pull request Jul 3, 2020
Closed
@lyrixx
Copy link
Contributor

lyrixx commented Jul 3, 2020

Yes, it's much better (no BC / more doc)
Thanks for taking care of it. I was a bit busy yesterday - I had to prepare a talk I gave this morning :)

@goetas goetas merged commit 5376d40 into master Jul 3, 2020
@goetas
Copy link
Member Author

goetas commented Jul 3, 2020

Alright! Thanks for digging that deep into this memory issue @lyrixx!

@goetas goetas deleted the mitigate-cyclic-refs branch July 5, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goetas @lyrixx