Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comment handling issues #218

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Address comment handling issues #218

merged 2 commits into from
Aug 18, 2022

Conversation

ohader
Copy link
Contributor

@ohader ohader commented Aug 18, 2022 •
edited
Loading

  • Correctly handle comment end bang state
  • Avoid Scanner::peek reading beyond end of data

Fixes: #215
Fixes: #217

@ohader
Avoid Scanner::peek reading beyond end of data
5fb0b2d 
Masterminds\HTML5\Parser\Scanner::peek() reads beyond the end of
actual data, which leads to a "Uninitialized string offset" warning.

Fixes: Masterminds#215
@ohader
Correctly handle comment end bang state
c2aeec0 
See section 8.2.4.52 of W3C HTML5 specs:
https://www.w3.org/TR/2017/REC-html52-20171214/syntax.html#comment-end-bang-state

Fixes: Masterminds#217
@goetas goetas merged commit 94375b8 into Masterminds:master Aug 18, 2022
@goetas
Copy link
Member

goetas commented Aug 18, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly handle comment end bang state Uninitialized string offset in src/HTML5/Parser/Scanner.php:108
2 participants
@ohader @goetas