Fixed infinite loop for char "&" in unquoted attribute #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that my server was overloaded by Apache's threads because of infinite loops in this library. Reproducible example:
And file
test.html
There are more pages that is causing overload of my server so I checked some of them and noticed it is caused by character ampersand (no matter if it's valid entity or not) in unquoted attribute. It's possible that some another infinite loop in library exists, but I can't check all of the pages. If I discover another one infinite loop I create an issue at least :)