-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML parsing options #74
Conversation
flexible HTML DOM creation. New Options: * disableHtmlNsInDom = Allows the use of createElement instead of createElementNS for HTML elements. * targetDocument = allows an existing DOMDocument (or subclass thereof) to be passsed to the DOMTreeBuilder instead of creating a new one.
8d51ad4
to
a5f8b8c
Compare
effaccd
to
a50e919
Compare
@mattfarina @technosophos On monday i'm planning to merge this and release the 2.1.0 version. Any thoughts? //cc @jslegers |
* `disable_html_ns` (boolean): Prevents the parser from automatically | ||
assigning the HTML5 namespace to the DOM document. This is for | ||
non-namespace aware DOM tools. | ||
* `target_doc` (\DOMDocument): A DOM document that will be used as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this: the code expects 'target_document' but the docs say 'target_doc', which shall we change to make it consistent?
@cognifloyd fixed on |
Closes #69
This change has to be integrated