Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP7 #82

Merged
merged 1 commit into from
Apr 11, 2015
Merged

Support for PHP7 #82

merged 1 commit into from
Apr 11, 2015

Conversation

goetas
Copy link
Member

@goetas goetas commented Apr 3, 2015

See: https://travis-ci.org/Masterminds/html5-php/builds/57083554

PHP interpreter test suite results
PHP 5.6 Time: 14.27 seconds, Memory: 20.25Mb
PHP HHVM Time: 4.64 seconds, Memory: 16.15Mb
PHP 7 Time: 157 ms, Memory: 6.00Mb

Does it mean that PHP7 is 90x faster? 😱 😱 😱 😱 😱

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.98% when pulling 73260cc on php7 into 28490e9 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.98% when pulling 73260cc on php7 into 28490e9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.98% when pulling 73260cc on php7 into 28490e9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.98% when pulling 73260cc on php7 into 28490e9 on master.

@mattfarina
Copy link
Member

Yay. the last time I tried this composer was failing. Glad to see it working.

Is there a reason we shouldn't merge this now?

goetas added a commit that referenced this pull request Apr 11, 2015
@goetas
Merge pull request #82 from Masterminds/php7
6222ad4 
Support for PHP7
@goetas goetas merged commit 6222ad4 into master Apr 11, 2015
@goetas
Copy link
Member Author

goetas commented Apr 11, 2015

nope!

@PhenX
Copy link

PhenX commented Apr 11, 2015

This is so awesome, I can't believe it's true :O
Are we sure it is working on php7 ? :-)

@goetas
Copy link
Member Author

goetas commented Apr 26, 2015

As discovered by @mattfarina with #83, the performance difference is because of xdebug. Disabling xdebug the result is 201ms vs 341ms.

See php7 and php5.6 travis builds

@goetas goetas deleted the php7 branch June 15, 2015 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goetas @coveralls @mattfarina @PhenX