Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #93

Merged
merged 2 commits into from
Jan 14, 2016
Merged

Update composer.json #93

merged 2 commits into from
Jan 14, 2016

Conversation

ericdowell
Copy link
Contributor

Updated satooshi/php-coveralls package to 1.0.* so guzzlehttp/guzzle (~6.0) is used instead of old deprecated guzzle/guzzle (3.9.4)

1.0 claims to still support PHP 5.3.3 and above (https://github.com/satooshi/php-coveralls/releases/tag/v1.0.0), plus this package you only use for testing anyways.

Updated satooshi/php-coveralls package to 1.0.* so guzzlehttp/guzzle (~6.0) is used instead of old deprecated guzzle/guzzle (3.9.3)
@ericdowell
Copy link
Contributor Author

Nightly in Travis has changed from 7.0.0-dev to 7.1.0-dev, maybe Nightly PHP shouldn't be tested. Instead add 7.0 to your .travis file.

All other versions of PHP pass tests (don't fail when running phpunit)

@ericdowell
Copy link
Contributor Author

Will gladly add to PR.

@goetas
Copy link
Member

goetas commented Jan 14, 2016

Looks good to me. thanks!

goetas added a commit that referenced this pull request Jan 14, 2016
@goetas goetas merged commit 97f171b into Masterminds:2.x Jan 14, 2016
@ericdowell ericdowell deleted the patch-1 branch January 14, 2016 20:11
@ericdowell
Copy link
Contributor Author

@goetas wasn't added to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants