add getHostByName function to resolve dns names to ips

[fcgravalos]

Hi guys!

This is a proposal to add a function to resolve names to IPs. I'm a heavy user of helm and this is useful where you need to render an IP but you don't want to hardcode it in your templates.

What do you think?

[fcgravalos]

Any chance I get feedback on this?

[mattfarina]

Note, in the future if more network functions are created the file for them should be renamed.

[mattfarina]

Two pieces of feedback:

1. Can you name the file network.go and network_test.go
2. Can you update the documentation to include this function

[fcgravalos]

Two pieces of feedback:

1. Can you name the file network.go and network_test.go
2. Can you update the documentation to include this function

Thanks for the feedback!!

Done!

[mattfarina]

Looks like a copy and paste error. This is the network functions not the string ones.

[fcgravalos]

sorry dude, I'll fix it

[mattfarina]

I'm sorry I didn't catch this before but returning an error has some consequences. It stops execution of the template where it is at and returns an error from Execute. You can see an example with this function at https://play.golang.org/p/d1f0BridbDc.

For sprig v3 we are going to add error handling via #132 and expanding it to cover any others.

Would you mind ignoring the error for now and we'll add that back when we have a consistent setup for both with and without error handling at that level.

For what it's worth, v3 is coming this month.

[fcgravalos]

Sure no problem at all!! :). I'll ignore the error

[fcgravalos]

I'll remove error catching from the test as well

[fcgravalos]

@mattfarina it seems one of the build steps failed due to a connectivity issue towards git.luolix.topm can we re-trigger the job? I didn't find the way to do it

Cloning into 'Masterminds/sprig'...
fatal: unable to access 'https://github.com/Masterminds/sprig.git/': Failed to connect to github.com port 443: Connection timed out

[mattfarina]

re-running that test

[mattfarina]

The testing error is due to the setup target not being on master any longer. strange.

[fcgravalos]

Thanks @mattfarina!!