add go.mod file #183
Closed
add go.mod file #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a recent release, 2.19.0, mentioned bumping the major version of this module, I thought I would prepare this change before that happens. This change bumps the semantic import version to github.com/Masterminds/sprig/v3, and will require an accompanying v3.0.0 tag. It is not suggested that this change merge before you are done with the v2.x.x line. This change is also important because in go1.13 incompatible packages are being deprecated. That is those with v2+ tags, without semantic import versions, that show up as vx.y.z+incompatbile. See the release notes https://golang.org/doc/go1.13#version-validation for more details. Fixes #145
|
With the merger of #186 this has been accomplished. So, I'm going to close this PR. Note, the other one updates semver to v3 which came out using go modules. A release of v3 will be coming soon so this can be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a recent release, 2.19.0, mentioned bumping the major version of
this module, I thought I would prepare this change before that happens.
This change bumps the semantic import version to
github.com/Masterminds/sprig/v3, and will require an accompanying v3.0.0
tag. It is not suggested that this change merge before you are done with
the v2.x.x line.
This change is also important because in go1.13 incompatible packages are
being deprecated. That is those with v2+ tags, without semantic import
versions, that show up as vx.y.z+incompatbile. See the release notes
https://golang.org/doc/go1.13#version-validation for more details.
Fixes #145