Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KMM] Add PlatformSpecificCheckboxView to demonstrate usage of compose-swift-bridge plugin #31

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JuliaJakubcova
Copy link
Collaborator

📝 Description

  • Add PlatformSpecificCheckboxView to demonstrate usage of compose-swift-bridge plugin

💡 What’s new?

  • New expect/actual view with the new plugin annotation, implementation in swift code

😶 What’s missing?

  • Nothing

📚 References

vojta-horanek
vojta-horanek previously approved these changes Nov 26, 2024
Copy link
Member

@vojta-horanek vojta-horanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@@ -30,3 +35,45 @@ dependencies {

ktlintRuleset(libs.ktlint.composeRules)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, could the whole CSB configuration be extracted to its own convention plugin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to try it as well, since it's a lot of ugly code 😄

Seidak
Seidak previously approved these changes Nov 26, 2024
tomas-bat
tomas-bat previously approved these changes Nov 28, 2024
Copy link
Collaborator

@tomas-bat tomas-bat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳

@JuliaJakubcova JuliaJakubcova force-pushed the feature/kmm/compose-swift-bridge-example branch from 1477564 to 77d90cb Compare November 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants