Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #48

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Fix deprecation warnings #48

merged 7 commits into from
Oct 29, 2023

Conversation

dafurman
Copy link
Contributor

Context
I'm interested in using and contributing to this library a bit, but I saw there were a bunch of deprecation warnings. Most of them could be resolved with fix-its, and the few ones that didn't have fix-its weren't too bad. Figured I'd fix them to make the repo nicer to work in without all the ⚠️.

Testing
Existing tests pass
Screenshot 2023-10-28 at 12 49 25 PM

@codecov
Copy link

codecov bot commented Oct 29, 2023

Copy link
Owner

@Matejkob Matejkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,

Firstly, thank you for addressing the deprecation warnings. I'm well aware that the swift-syntax has been evolving rapidly, and with the advancements from WWDC to the official release of Swift 5.9, the API of the Swift syntax tree has undergone significant changes. This is likely the reason for the multitude of warnings we've been seeing. Your effort to not only notice but also rectify these warnings is commendable. Everything looks great on my end, and the fact that all existing tests pass speaks volumes about your meticulous approach.

I truly appreciate contributors like you who take the time to adapt to and improve upon the evolving codebase. Thanks again for your valuable contribution, and I'm eager to see more of your work in the future!

Thank you!

@Matejkob Matejkob merged commit f9d8923 into Matejkob:main Oct 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants