Support UDS listen address for tokio-console #16537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes local tokio-console support, which was broken in ac1028d because tokio-console does not support Unix domain sockets (yet, see: tokio-rs/console#388).
The fix involves adding that support by switching to @benesch's fork of concole-subscriber and using the
mz_ore::netio::SocketAddr
type for the tokio-console listen address.It is now also required to use the forked version of the tokio-console CLI client. The developer docs are updated to reflect this.
Motivation
Running
environmentd
with tokio-console support enabled is broken:Checklist
This PR has adequate test coverage / QA involvement has been duly considered.
This PR evolves an existing
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-proto
label.This PR includes the following user-facing behavior changes: