Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix grammar of mat view WITH options #27325

Merged
merged 2 commits into from
Jun 18, 2024

Commits on Jun 7, 2024

  1. docs: Fix grammar of mat view WITH options

    Fixes two issues:
    - It looked as if `WITH ()` would be possible.
    - It looked as if `ASSERT NOT NULL` and `RETAIN HISTORY` can come
      only in this order, but actually `ASSERT NOT NULL` can be specified
      also after `RETAIN HISTORY` (even both before and after).
    
    Note that the new diagram is also not perfect, because now it looks as
    if `RETAIN HISTORY` could be specified more than once. I think we have
    to accept this, because it seems impossible to exactly specify using
    BNF that these options can be specified in any order, and `ASSERT NOT
    NULL` can be specified any number of times, but `RETAIN HISTORY` can
    only be specified once.
    
    Also, the new layout seems cleaner overall, especially when I add
    REFRESH soon.
    
    Note that I did not add the optional `=` for `ASSERT NOT NULL`. Started
    a discussion on this here:
    https://materializeinc.slack.com/archives/C063H5S7NKE/p1716888019218749
    
    Plus the commit removes a stale PrPr notice fragment for
    ASSERT NOT NULL.
    ggevay committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    35041de View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Restructure

    morsapaes committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    96d48c3 View commit details
    Browse the repository at this point in the history