Upgrade hugo #27679
Merged
Upgrade hugo #27679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.File` can potentially be nil on pages that can't be mapped to a file (e.g., directories without an `_index.md`), so add a guard around the GitHub docs link in the footer.
Newer versions of Hugo (>0.87) changed how relative URLs are generated. These new URLs cause surprising behavior when hosted within a subdirectory. Add logic to our link and image shortcodes to read the path from the Hugo config and prepend it to any relative URL.
5 tasks
8 tasks
5 tasks
benesch
added a commit
to benesch/materialize
that referenced
this pull request
Jun 27, 2024
The upgrade to Hugo v0.124.1 in MaterializeInc#27679 has broken the deploy_website build. The issue appears to be a bug in the Go AWS SDK version that Hugo v0.124.1 uses that causes credential refreshing to sporadically fail. The latest version of Hugo (v0.128) incoporates a Go AWS SDK upgrade that hopefully fixes the issue.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our current version of Hugo is fairly out of date, and engineers are encountering issues trying to author docs. This upgrades us to a recent version of Hugo and makes the necessary changes to make the generated docs functional. Beyond the version bump this includes:
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.