Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog: simplify open_debug_catalog implementation #27724

Merged

Conversation

benesch
Copy link
Member

@benesch benesch commented Jun 18, 2024

Ignore for now. This failed CI when it was in a slightly different form (using NOW_ZERO instead of SYSTEM TIME). I'm hoping this form works better.


All of these tests are fine with using SYSTEM_TIME as the NowFn.

Motivation

  • This PR refactors existing code.

Checklist

All of these tests are fine with using SYSTEM_TIME as the NowFn.
@benesch benesch requested a review from a team as a code owner June 18, 2024 04:59
@benesch benesch requested a review from jkosh44 June 18, 2024 04:59
@benesch benesch marked this pull request as draft June 18, 2024 05:00
@jkosh44
Copy link
Contributor

jkosh44 commented Jun 20, 2024

@benesch Give me a ping if/when this is ready for review.

@benesch benesch marked this pull request as ready for review June 21, 2024 04:11
@benesch
Copy link
Member Author

benesch commented Jun 21, 2024

It's ready! CI seems happy with this.

Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benesch benesch merged commit 7c5d23a into MaterializeInc:main Jun 21, 2024
79 checks passed
@benesch
Copy link
Member Author

benesch commented Jun 21, 2024

Thank you!

@benesch benesch deleted the catalog-test-api-simplification branch June 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants