Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MzContainerized, use in reachability logging #27743

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jun 18, 2024

Introduce a MzContainerized trait that associates types to regions, while allowing to specify a owned type that is different to Self. Switches reachability logging to send flat containers over dataflow edges. Changes mz_replay to accept a closure to produce data.

Related: #27741

Part of #13038

Checklist

@antiguru antiguru force-pushed the reachability_flatcontainer branch 3 times, most recently from 883b1ff to 5866672 Compare June 24, 2024 18:31
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
@antiguru antiguru marked this pull request as ready for review June 24, 2024 19:40
@antiguru antiguru requested review from a team and benesch as code owners June 24, 2024 19:40
@benesch benesch removed their request for review June 24, 2024 19:55
Copy link
Contributor

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with some comments about clarity and stumbling blocks I found.

src/ore/src/flatcontainer.rs Outdated Show resolved Hide resolved
src/compute/src/logging/initialize.rs Outdated Show resolved Hide resolved
src/compute/src/logging/initialize.rs Outdated Show resolved Hide resolved
src/compute/src/logging/initialize.rs Outdated Show resolved Hide resolved
src/compute/src/logging.rs Outdated Show resolved Hide resolved
src/compute/src/logging/initialize.rs Outdated Show resolved Hide resolved
src/compute/src/typedefs.rs Show resolved Hide resolved
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
@antiguru antiguru merged commit 00563cd into MaterializeInc:main Jun 25, 2024
77 checks passed
@antiguru antiguru deleted the reachability_flatcontainer branch June 25, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants