compute: write unified introspection updates to storage #27767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
teskje
force-pushed
the
unified-introspection-write
branch
from
97c18e2
to
4b1d5a4
Compare
5 tasks
teskje
force-pushed
the
unified-introspection-write
branch
5 times, most recently
from
eb5fc67
to
9550045
Compare
5 tasks
|
LGTM from a SQL council point of view. |
maddyblue
approved these changes
Jul 1, 2024
|
Aborted, I noticed you already had one running. 👍 |
teskje
force-pushed
the
unified-introspection-write
branch
2 times, most recently
from
522281d
to
d7febfb
Compare
|
TFTRs! |
This commit adds the necessary storage controller calls to write updates received from introspection subscribes to their respective target storage collections, and retract them when an introspection subscribe is dropped.
This commit adds the first unified compute introspection relation, `mz_compute_error_counts_raw_unified`, the unified equivalent of `mz_compute_error_counts_raw`. Ideally we'd name the new relation `mz_compute_error_counts_raw` too, but we cannot do so until we have removed the automatic translation of the `mz_internal` schema to `mz_introspection`, as otherwise bootstrapping encounters a naming conflict with the per-replica introspection source. Note that we cannot yet define the `mz_compute_error_count` view on top of `mz_compute_error_counts_unified_raw` as that view also depends on other introspection relations that haven't been unified yet.
teskje
force-pushed
the
unified-introspection-write
branch
from
d7febfb
to
5d1afa8
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up the unified compute introspection MVP by adding the missing code to write updates from introspection subscribes to storage, as well as a first unified relation,
mz_compute_error_counts_raw_unified.Motivation
Closes #26730
Tips for reviewer
Commits can be reviewed independently.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.