persist: Add columnar format to HollowBatchPart
#27800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkirwi
approved these changes
Jun 26, 2024
| Some(cfg.batch_columnar_format) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
I think this may fail to roundtrip during upgrade, if a batch with a columnar format is written by a new version but retracted by the old version without the proto change.
This is probably fine iff no environments currently have the new columnar format enabled, but otherwise you may want an additional flag?
There was a problem hiding this comment.
Makes sense! I think adding a second flag to control the writing is easier to reason about so I updated the PR to do that
ParkMyCar
force-pushed
the
persist/save-columnar-version
branch
from
a38c6e9
to
22e3f91
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the format of a
Part(e.g. Row or RowAndColumnar) to theHollowBatchPart, so our format is observable from CRDB state without having to read a blob.Dan originally mentioned adding this to
HollowBatch, which I tried but it seems like we might concat the parts from multiple batches into a single batch, which creates the possibility for a singleBatchto containParts with different formats.@bkirwi I'm not sure what our stability guarantees are for
HollowBatchPart. I added this in a way that should be backwards and forwards compatible, but please double check me hereMotivation
Making columnar format observable from State, follow-up from #26561 (review)
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.