Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: don't use max_query_result_size in RTW plans #27807

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

maddyblue
Copy link
Contributor

Avoid max_query_result_size in the read portion of read-then-write plans. Previously that session var would limit the size of the updates to its setting. This would cause, for example, a DELETE issued from the console to fail if there were more than 1MB of rows in a table.

Fixes MaterializeInc/database-issues#8099

Motivation

  • This PR fixes a recognized bug.

Checklist

Avoid max_query_result_size in the read portion of read-then-write plans.
Previously that session var would limit the size of the updates to its setting.
This would cause, for example, a `DELETE` issued from the console to fail if
there were more than 1MB of rows in a table.

Fixes #27428
@maddyblue maddyblue requested review from a team as code owners June 22, 2024 01:23
@maddyblue maddyblue requested a review from jkosh44 June 22, 2024 01:23
@maddyblue
Copy link
Contributor Author

Not convinced this is the best way to do it (there's a bunch of plumbing down to the last step), but this is the common place where RTW and user peeks happen, so kinda makes sense.

@maddyblue maddyblue merged commit a4fbaf0 into MaterializeInc:main Jun 24, 2024
77 checks passed
@maddyblue maddyblue deleted the max-query-size branch June 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants