-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pending field to managed cluster replicas #27808
add pending field to managed cluster replicas #27808
Conversation
367ee40
to
e3a3101
Compare
Did someone on @MaterializeInc/adapter review the design doc for this? If so, they'd probably be a better reviewer than me. |
I'll review! |
e3a3101
to
6de244f
Compare
6de244f
to
406bb18
Compare
MitigationsCompleting required mitigations increases Resilience Coverage.
Risk Summary:The pull request poses a high risk with a score of 79, indicating a significant likelihood of introducing a bug. This assessment is driven by predictors such as the sum of bug reports in the files changed and the delta of executable lines. Notably, there has been a historical trend showing that pull requests with these characteristics are 108% more likely to cause a bug compared to the repository's baseline. Additionally, the repository's predicted bug trend is on the rise, and there is at least one file modified that has a high frequency of recent bug fixes. Note: The risk score is not based on semantic analysis but on historical predictors of bug occurrence in the repository. The attributes above were deemed the strongest predictors based on that history. Predictors and the score may change as the PR evolves in code, time, and review activity. Bug Hotspots:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nightly lgtm: https://buildkite.com/materialize/nightly/builds/8211#_
Coverage only shows upgrade tests missing (expected): https://buildkite.com/materialize/coverage/builds/430
I'll add a commit to test persisting the pending field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see, this is actually just a new column in mz_cluster_replicas. I'm wondering why test/sqllogictest/autogenerated/mz_catalog.slt
's SELECT position, name, type FROM objects WHERE schema = 'mz_catalog' AND object = 'mz_cluster_replicas' ORDER BY position
didn't have to be changed? It seem like we should document and check the new fields too.
@def- this doesn't yet expose the field as a column in mz_cluster_replicas. Really there should be no functional changes from this pr, just a new field being added to the catalog that for now is always false. Eventually we will expose it, but we'll want to wait for the rest of graceful reconfig functionality before we do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All test failures are unrelated flakes, fixed in main.
Motivation
More prep for graceful reconfig.
Reconfiguration replicas that come up will have a suffixed with
-pending
and will have a pending field in the cluster replica config.https://github.com/MaterializeInc/database-issues/issues/5976
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.