add Container implementation for StackedWrapper
#27810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pure code movement of the containers module to the mz_timely_util crate so that it can be reused from more places. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
antiguru
approved these changes
Jun 22, 2024
| @@ -11,6 +11,8 @@ workspace = true | |||
|
|
|||
| [dependencies] | |||
| differential-dataflow = "0.12.0" | |||
| either = "1" | |||
There was a problem hiding this comment.
Do we actually use either? Can't see it on mobile!
There was a problem hiding this comment.
Yes, the stacked wrapper needs to define an iterator associated type which either the one from timelystack or the one from chunkedstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR has a pure code moment commit (the first one) that moves the
mz_compute::containersmodule intomz_timely_utiland an implementation ofContainerforStackedWrapperso that it can be used to move data between timely operators.Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.