timely-util: make AsyncOutputHandle::give generic over the container builder
#27825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
requested review from
aljoscha,
danhhz,
jkosh44 and
a team
as code owners
petrosagg
force-pushed
the
async-builder-containers
branch
from
3de0eeb
to
3428688
Compare
antiguru
approved these changes
Jun 24, 2024
| @@ -19,6 +19,7 @@ use std::hash::Hash; | |||
| use std::pin::Pin; | |||
| use std::sync::Arc; | |||
| use std::time::Instant; | |||
| use timely::container::CapacityContainerBuilder; | |||
There was a problem hiding this comment.
Nit: move down to the next block.
src/timely-util/src/builder_async.rs
Outdated
| { | ||
| #[allow(clippy::unused_async)] | ||
| pub async fn give<C: CapabilityTrait<T>>(&mut self, cap: &C, data: D) { | ||
| pub async fn give<C, D>(&mut self, cap: &C, data: D) |
There was a problem hiding this comment.
You could use the same trick that timely uses: Implement give for a handle that is specialized to CapacityContainerBuilder and generic over a container, and add a separate give_with_builder that's implemented for handles generic over any container builder. This would remove the need for the second commit.
There was a problem hiding this comment.
Great idea! I actually only want give to be generic over the container so I'll skip adding a give_with_builder for now
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
async-builder-containers
branch
from
3428688
to
ea1be38
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enables using the
.give()API for any container builder that supports it. Only the first commit needs to be reviewed, the second one is a mechanical change since more type annotations are now needed that were previously inferred.Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.