storage/mysql: Replace enable_mysql_source with max_mysql_connections var #27847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
reviewed
Jun 24, 2024
There was a problem hiding this comment.
I triggered nightly just in case this has some weird side effects with upgrades: https://buildkite.com/materialize/nightly/builds/8207
def-
requested changes
Jun 24, 2024
benesch
reviewed
Jun 24, 2024
| @@ -432,6 +432,13 @@ pub static MAX_POSTGRES_CONNECTIONS: VarDefinition = VarDefinition::new( | |||
| false, | |||
| ); | |||
|
|
|||
| pub static MAX_MYSQL_CONNECTIONS: VarDefinition = VarDefinition::new( | |||
| "max_mysql_connections", | |||
| value!(u32; 0), | |||
There was a problem hiding this comment.
Your life will probably be much easier if you default this to 1000, and then use LD in production to set it back to 0 by default for production environments.
There was a problem hiding this comment.
ah great idea - will do
There was a problem hiding this comment.
sounds good, set up the LD flag in prod to do so https://app.launchdarkly.com/projects/default/flags/max_mysql_connections/targeting?env=production&env=staging&env=development&env=loadtest&env=ci-cd&selected-env=production
rjobanp
force-pushed
the
mysql-connection-limit
branch
4 times, most recently
from
cff8c90
to
93ec7b8
Compare
rjobanp
force-pushed
the
mysql-connection-limit
branch
from
93ec7b8
to
01339f5
Compare
def-
approved these changes
Jun 25, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Parity with other source types, and the ability to query this variable from the Console (via SQL). See https://materializeinc.slack.com/archives/C01CFKM1QRF/p1715228421858309?thread_ts=1715209780.830859&cid=C01CFKM1QRF for more context
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.