Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/mysql: fix bad boolean logic causing unnecessary enforcement of 'replica_preserve_commit_order' config #27871

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Jun 25, 2024

Motivation

  • This PR fixes a previously unreported bug.

I wrote a bug 😮‍💨 -- this is causing the is_multi_threaded flag to always be set to true which is enforcing the replica_preserve_commit_order even when unnecessary. See the docstring on this method for context on this setting.

Tips for reviewer

Checklist

@rjobanp rjobanp requested a review from petrosagg June 25, 2024 15:54
@rjobanp rjobanp requested a review from a team as a code owner June 25, 2024 15:54
@rjobanp rjobanp merged commit da54fb5 into MaterializeInc:main Jun 25, 2024
76 checks passed
@rjobanp rjobanp deleted the mysql-bool-logic-commit-order branch June 25, 2024 16:46
rjobanp added a commit that referenced this pull request Jun 25, 2024
storage/mysql: fix bad boolean logic causing unnecessary enforcement of 'replica_preserve_commit_order' config
rjobanp added a commit that referenced this pull request Jun 25, 2024
storage/mysql: fix bad boolean logic causing unnecessary enforcement of 'replica_preserve_commit_order' config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants