adapter: cluster status updates don't go through catalog_transact() #27877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work towards zero-downtime upgrades: MaterializeInc#27406 Now, they are regular builtin table updates. This will make them easier to work with in future changes where I introduce support for read-only mode in the adapter.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards zero-downtime upgrades: #27406
Now, they are regular builtin table updates. This will make them easier to work with in future changes where I introduce support for read-only mode in the adapter.
Tips for reviewer
I'm not 100% sure what protections the previous path through
catalog_transactgave us. But we produce builtin table updates in other places where we don't go throughcatalog_transactand those seem to be fine.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.