Fix page header URL interpolation following Hugo upgrades #27878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two issues following the Hugo upgrade. - The `BaseURL` parameter has a trailing slash, so concatenation for favicon paths was generating invalid URLs. - The `og:url` property was generating duplicated `/docs/docs/` paths. Let's always rely on the permalink.
morsapaes
approved these changes
Jun 25, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This addresses two issues following the Hugo upgrade.
BaseURLparameter has a trailing slash, so concatenation for favicon paths was generating invalid URLs.og:urlproperty was generating duplicated/docs/docs/paths. Let's always rely on the permalink.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.