Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: show cluster name and id in insights #27885

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

maddyblue
Copy link
Contributor

Although the text name is present in the explain plans, it's hard to parse, not in the JSON output, and doesn't include the cluster id.

Motivation

  • This PR adds a feature that has not yet been specified.

Checklist

@maddyblue maddyblue requested review from a team as code owners June 26, 2024 05:06
@maddyblue maddyblue requested a review from jkosh44 June 26, 2024 05:06
@maddyblue
Copy link
Contributor Author

Not sure if someone from the cluster team thinks this should go elsewhere, like in one of the json plans as an analog to the text output. It wasn't obvious to me how to do that so I put it in an easier place instead.

@maddyblue
Copy link
Contributor Author

fyi @SangJunBak

Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although the text name is present in the explain plans, it's hard to parse, not
in the JSON output, and doesn't include the cluster id.
@maddyblue maddyblue merged commit e59a416 into MaterializeInc:main Jun 26, 2024
76 checks passed
@maddyblue maddyblue deleted the cluster-insight branch June 26, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants