Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: cargo-gazelle fix rust_binary name collision, upgrade Rust version #27894

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

ParkMyCar
Copy link
Member

It's relatively common for Rust library targets and binary targets to have the same name, e.g. when you have a lib.rs and a main.rs. cargo-gazelle had some automatic detection for this, but it looks like it broke after the most recent Rust upgrade because Cargo changed from a snake_case default to kebab-case.

This PR changes the name collision detection to explicitly use snake_case. It also updates the version of Rust that Bazel uses to be the same as the default one we build with.

Motivation

Fixes cargo-gazelle

Checklist

@ParkMyCar ParkMyCar merged commit 7a9de7b into MaterializeInc:main Jun 26, 2024
16 checks passed
@ParkMyCar ParkMyCar deleted the bazel/fix-cargo-gazelle branch October 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants