mz: faster feedback on invalid region names #27902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinClowers
force-pushed
the
mz-better-error-for-invalid-region
branch
from
b3b1e20
to
484e927
Compare
RobinClowers
changed the title
RobinClowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fat-fingered the region name, and mz appeared stuck saying "Retrieving information". After looking at the code I realized it was retrying the request with backoff. This behavior is important for the actual disable request, but the region fetch should fail fast. I also updated the error message and names of functions and the error enum to be more clear.
Motivation
Tips for reviewer
First mz contribution, all feedback appreciated!
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.