test analytics: add logging #27914
Merged
test analytics: add logging #27914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Jun 27, 2024
| @@ -22,7 +23,7 @@ def __init__(self, database_connector: DatabaseConnector): | |||
| def query_data( | |||
| self, | |||
| query: str, | |||
| verbose: bool = False, | |||
| verbose: bool = True, | |||
There was a problem hiding this comment.
Yes (a02243e), to gain some insights about durations.
nrainer-materialize
force-pushed
the
test-analytics/logging
branch
from
a02243e
to
d62da10
Compare
nrainer-materialize
force-pushed
the
test-analytics/logging
branch
from
d62da10
to
a4f5311
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
034ae9e test analytics: improve logging
b84e099 test analytics: log duration of DML statements
d8bbda8 test analytics: log duration of queries
4c253a0 test analytics: enable verbose mode for queries for now
8f58358 test analytics: search: extract function
b77fb13 test analytics: search: print duration
a4f5311 test analytics: search: non-verbose mode for queries