Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Chroma syntax-generation script #27950

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

arusahni
Copy link
Contributor

Motivation

  • This PR adds a feature that has not yet been specified.
    Hugo uses Chroma for syntax highlighting. We upstreamed a Materialize-specific syntax to ensure our dialect's keywords are recognized as such. Now that the end-to-end change is in prod, let's automate the process of generating updates for the dialect lexer.

I have a PR filed against the Chroma repo that uses a version of the lexer generated by this script.

Tips for reviewer

Checklist

no user facing behavior changes

Hugo uses Chroma for syntax highlighting. We upstreamed a
Materialize-specific syntax to ensure our dialect's keywords are
recognized as such. Now that the end-to-end change is in prod, let's
automate the process of generating updates for the dialect lexer.
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making this usable by other folks on the team.

@arusahni arusahni merged commit 77ee7e7 into MaterializeInc:main Jun 29, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants