Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/sink/kafka: prevent queue full by disabling buffering #27964

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

benesch
Copy link
Member

@benesch benesch commented Jul 1, 2024

Now that we're on librdkafka v2.4.0, we don't need to catch and retry QueueFull errors, but can instead disable the queue limit.

This commit is a combination of:

Motivation

  • This PR refactors existing code.

Checklist

Now that we're on librdkafka v2.4.0, we don't need to catch and retry
QueueFull errors, but can instead disable the queue limit.

This commit is a combination of:

  * Reverting the QueueFull workaround from MaterializeInc#24871
  * Reapplying Petros's original implementation in MaterializeInc#24784

Co-authored-by: Petros Angelatos <petrosagg@gmail.com>
@benesch benesch requested a review from petrosagg July 1, 2024 01:45
@benesch benesch requested a review from a team as a code owner July 1, 2024 01:45
Copy link
Contributor

@petrosagg petrosagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good memory, I had forgotten about this workaround :D

@benesch benesch merged commit a9156b4 into MaterializeInc:main Jul 2, 2024
76 checks passed
@benesch benesch deleted the kafka-sink-buffering branch July 2, 2024 14:51
@petrosagg petrosagg mentioned this pull request Jul 3, 2024
5 tasks
ParkMyCar added a commit to ParkMyCar/materialize that referenced this pull request Jul 11, 2024
…nk-buffering"

This reverts commit a9156b4, reversing
changes made to 990747a.
ParkMyCar added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants