Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist: add metrics tracking fetch_upper calls #29230

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Aug 26, 2024

Discovered this hole in our persist introspection while debugging an increase in the number of consensus_scan calls in the latest release candidate.

Motivation

  • This PR adds a feature that has not yet been specified.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Discovered this hole in our persist introspection while debugging an
increase in the number of consensus_scan calls in the latest release
candidate.
@danhhz danhhz requested a review from ParkMyCar August 26, 2024 18:36
@danhhz danhhz requested a review from a team as a code owner August 26, 2024 18:36
@danhhz danhhz merged commit 5a12775 into MaterializeInc:main Aug 26, 2024
81 checks passed
@danhhz danhhz deleted the persist_metrics_fetchupper branch August 26, 2024 20:34
@danhhz
Copy link
Contributor Author

danhhz commented Aug 26, 2024

TFTR!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants