Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Upgrade to 1.83.0 #30872

Merged
merged 4 commits into from
Jan 2, 2025
Merged

rust: Upgrade to 1.83.0 #30872

merged 4 commits into from
Jan 2, 2025
+231 −191

Conversation

ParkMyCar
Copy link
Member

@ParkMyCar ParkMyCar commented Dec 19, 2024 •
edited
Loading

This PR does two things:

  1. Upgrades the version of Rust we use to 1.83.0, and fixes a bunch of clippy lints
  2. Expands the instructions in upgrade-rust.md to include how to upgrade Rust for Bazel

Motivation

Get us on a newest version of Rust

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar marked this pull request as ready for review December 20, 2024 18:46
@ParkMyCar ParkMyCar requested review from a team, aljoscha and jkosh44 as code owners December 20, 2024 18:46
jkosh44
jkosh44 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/compute/src/row_spine.rs
Comment on lines +329 to +332
type DatumIter<'short>
= DatumSeq<'short>
where
Self: 'short;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, how does rustfmt find this better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol I know, I was quite surprised with this one 😂

def-
def- approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope no compilation time regressions this time!

@ParkMyCar ParkMyCar enabled auto-merge (squash) December 29, 2024 19:11
@ParkMyCar ParkMyCar merged commit 74ebdd6 into MaterializeInc:main Jan 2, 2025
84 checks passed
def- added a commit to def-/materialize that referenced this pull request Jan 2, 2025
@def-
ci-builder: Bump nightly rust version to be 1.83.0 compatible
71f3896 
Follow-up to MaterializeInc#30872

Noticed in https://buildkite.com/materialize/deploy/builds/17226#019427a7-9f03-4ce4-bac9-16c6ab9a3bff
@def- def- mentioned this pull request Jan 2, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

@jkosh44 jkosh44 jkosh44 approved these changes

@def- def- def- approved these changes

@antiguru antiguru antiguru approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ParkMyCar @antiguru @def- @jkosh44 @bobbyiliev