Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize] MRE::typ(): remove call in ReductionPushdown #30876

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

mgree
Copy link
Contributor

@mgree mgree commented Dec 19, 2024

Part of MirRelationExpr::typ() cleanup.

Skip a call to typ() that is only for arity.

Motivation
This PR adds a known-desirable feature.
https://github.com/MaterializeInc/database-issues/issues/2488
https://github.com/MaterializeInc/database-issues/issues/3779
https://github.com/MaterializeInc/database-issues/issues/4959

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@mgree mgree requested a review from a team as a code owner December 19, 2024 20:51
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mgree mgree merged commit c892f3e into MaterializeInc:main Dec 23, 2024
79 checks passed
@mgree mgree deleted the mre-typ-ballast-reduction-pushdown branch December 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants