testdrive: Some fixes for duplicate args #30918
Merged
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
force-pushed
the
pr-testdrive-duplicate-args
branch
from
1c4a2e0 to
965ce96
Compare
We still can't remove the duplicate argument handling because testdrive's usage is a bit convoluted. We create containers with a set of defaults, and then sometimes have to invoke it with different parameters through run_testdrive_files etc.
def-
force-pushed
the
pr-testdrive-duplicate-args
branch
from
965ce96 to
c677fc4
Compare
def-
changed the title
|
@alex-hunt-materialize Is this ok for you? I feel like it might not be worth changing the way testdrive functions as it makes extensive use of having a set of default settings and overwriting them in specific calls |
alex-hunt-materialize
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #30895
We still can't remove the duplicate argument handling because testdrive's usage is a bit convoluted. We create containers with a set of defaults, and then sometimes have to invoke it with different parameters through run_testdrive_files etc.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.