Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clap v4 #30919

Merged

Conversation

alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented Dec 30, 2024

Bump clap to v4.5.23.
Also bumps criterion, to remove clap v3.

Motivation

Clap v3 has been out of date for years at this point, and we've been running yanked versions of it for a long time now.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize force-pushed the bump_clap_v4 branch 4 times, most recently from fd07eb3 to 249d27c Compare January 2, 2025 11:32
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review January 2, 2025 16:20
@def-
Copy link
Contributor

def- commented Jan 2, 2025

Thanks for triggering nightly and making sure it's green! https://buildkite.com/materialize/nightly/builds/10765

@alex-hunt-materialize alex-hunt-materialize merged commit 380d202 into MaterializeInc:main Jan 2, 2025
225 of 233 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the bump_clap_v4 branch January 2, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants