Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrius Merkys <andrius.merkys@gmail.com>
  • Loading branch information
ml-evs and merkys committed Mar 17, 2024
1 parent 7e63263 commit 12c1d89
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions optimade.rst
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ A few suggestions and mandatory requirements of the OPTIMADE specification are s

..
**Note**: A list of database providers acknowledged by the **Open Databases Integration for Materials Design** consortium is maintained externally from this specification and can be retrieved as described in section `Namespace Prefixes`_.
**Note**: A list of database and definition providers acknowledged by the **Open Databases Integration for Materials Design** consortium is maintained externally from this specification and can be retrieved as described in section `Namespace Prefixes`_.
This list is also machine-readable, enabling the automatic discoverability of OPTIMADE API services.

Namespace Prefixes
Expand Down Expand Up @@ -425,7 +425,6 @@ They MAY also provide human-readable webpages for their definitions.

Definition-provider-specific fields MAY be fully described at the relevant :endpoint:`/info/<entry_type>` endpoint (see section `Entry Listing Info Endpoints`_), but can also rely on the canonical definitions provided by the definition provider, provided they return an ``$id`` for the field that resolves to the relevant OPTIMADE property definition.


URL Encoding
------------

Expand Down Expand Up @@ -3446,7 +3445,7 @@ Custom entry types MUST have all properties described above in section `Properti

- **Requirements/Conventions for properties in custom entry types**:

- **Support**: Support for any properties in database-provider-specific entry types is fully OPTIONAL.
- **Support**: Support for any properties in database-provider-specific or definition-provider-specific entry types is fully OPTIONAL.
- **Query**: Support for queries on these properties are OPTIONAL.
If supported, only a subset of the filter features MAY be supported.

Expand Down

0 comments on commit 12c1d89

Please sign in to comment.