Feedback & Code Review od Mentora Zespołu (Mateusz Nowak) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a GiHub Actions workflow to the project. Every time someone wants to merge commit into develop it will try to build application, run tests and upload new files on GitHub Pages. Build and test checks must pass to be able to merge.
* more project settings * fixes to settings * add ESLint * additional checks for ts code
Co-authored-by: lamparina <anna.lamperska@gmail.com>
…4 and there is no pieces on Pawn's way"
…ngAllyKingCheckmate
…pieceMovesNotCausingAllyKingCheckmate
…to_account_the_King's_check #43_Moves_a_piece_taking_into_account_the_King's_check
Build on windows
…abled (#80) * Add test * Change turn to avoid error * Add pawnPromotionWasEnabled event * Fix tests * Block move until promotion is done * Restore tests for check | Merge changes and resolve conflicts * Update lock file * Fix bug * Add missing test case Co-authored-by: lamparina <anna.lamperska@gmail.com>
* Initiall commit * Initiall commit * Add types * Fix name of pieceMovesNotCausingAllyKingCheck function * Add first test * Add second test * Finishtest * Add CheckmatedKing variable and isCheckmatedKing function * Delete last added function: isCheckmatedKing * After code review | Update tests * Add empty method in ChessEngine. Add code in move() method * Fix last commit * Add new test * Delete doubled test * Fix bug in test * Finish checkmateHasOccurred function, In progress: is PossibleMoves * Finish all without cleaning code. * EsLint CoderReview | Update * Add tests for Stalemate Has Occurred * Add type for Stalemate Has Occurred * Fix | Fix test for Stalemate Has Occurred * Fix | Fix test from others tasks because this tests had bug with stalemate event * Finish stalemate event service * Eslint CodeReview | Update
* Add positive and negative test cases for castling * CastlingWasDone - positive cases | Castling not possible while king's exposed to attack * Disable castling if king or rook has already moved or there is any piece between them * Refactor ChessEngine * Return all possible moves from one method * Rename method * Fix method name * Refactor possibleMoves method Co-authored-by: lamparina <anna.lamperska@gmail.com>
Z podziękowaniem dla @nowakprojects @lamparina @tomdworniczak @Szambelan za ładne CodeReview poprzedniego taska * Update | Change Stalemate and fix a small bug in test * Update | Change type of Stalemate event * Update | Delete imports * Update | Delete kingPosition problem
* Create modal window for pawn promotion * Selected figure to be promoted * Proba skonczenia zadanka * Rename modal's css classes * Promotion modal and it's test * Changes in modal event * #76 modal window for pawn promotion - Model * #76 make promotingOnSquare private again * #76 remove dead code * #76 CR fixes Co-authored-by: Pawel Szambelan <p.szambelan1@gmail.com> Co-authored-by: lamparina <59768305+lamparina@users.noreply.github.com> Co-authored-by: lamparina <anna.lamperska@gmail.com>
* First part * Add bg * next part * next part * next part * next part
* #70 Tests and draft solution * #70 Refactor test case * #70 Apply pawn attack in passing logic * #70 Remove silly test case * #70 Add return type to method * #70 Add test case * #70 delete unneeded if statement * #70 refactor * #70 merge develop * Add en passant to possibleMoves * Last fix Co-authored-by: lamparina <anna.lamperska@gmail.com> Co-authored-by: lamparina <59768305+lamparina@users.noreply.github.com>
Co-authored-by: lamparina <anna.lamperska@gmail.com>
Co-authored-by: lamparina <anna.lamperska@gmail.com>
* Update README.md Update README file * Update readme again * Add live version link and sreenshoots of a game Co-authored-by: lamparina <59768305+lamparina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.