Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure gem #3

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Add option to configure gem #3

merged 3 commits into from
Oct 25, 2021

Conversation

m3xq
Copy link
Contributor

@m3xq m3xq commented Oct 24, 2021

No description provided.

@m3xq
Copy link
Contributor Author

m3xq commented Oct 24, 2021

#1

@m3xq
Add config
9f54ddf 
Add specs for config

Bump version to 0.3.0

Update README.md

Update README.md

Run rubocop

Fix typo
MatheusRich
MatheusRich reviewed Oct 25, 2021
View reviewed changes
lib/ez_attributes.rb Outdated Show resolved Hide resolved
@MatheusRich
Copy link
Owner

@m3xq Thanks for your contribution! I was planning to use the module builder pattern here to avoid global mutable state. Do you wanna give a try on this? Also, LMK if you need me to add the hacktoberfest-accepted tag on this PR

@m3xq
Copy link
Contributor Author

m3xq commented Oct 25, 2021

@m3xq Thanks for your contribution! I was planning to use the module builder pattern here to avoid global mutable state. Do you wanna give a try on this? Also, LMK if you need me to add the hacktoberfest-accepted tag on this PR

Hi, can you merge this PR with hacktoberfest-accepted tag please? After that I'll make a new PR with module builder pattern. Is it ok?

@MatheusRich
Copy link
Owner

@m3xq I added the tag on your PR, so that should do it already. Also, make sure to run standardrb --fix on your files to fix linter errors. Please, use this same PR for the refactoring.

@m3xq
Copy link
Contributor Author

m3xq commented Oct 25, 2021

@MatheusRich Do you have any ideas how to do it better?

@m3xq m3xq changed the title Add config Add option to configure gem Oct 25, 2021
MatheusRich
MatheusRich reviewed Oct 25, 2021
View reviewed changes
lib/ez_attributes.rb Outdated Show resolved Hide resolved
MatheusRich
MatheusRich reviewed Oct 25, 2021
View reviewed changes
lib/ez_attributes.rb Outdated Show resolved Hide resolved
MatheusRich
MatheusRich reviewed Oct 25, 2021
View reviewed changes
Copy link
Owner

@MatheusRich MatheusRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but overall looking good! Thank you for the awesome work!

@m3xq
Copy link
Contributor Author

m3xq commented Oct 25, 2021

Everything seems to be ready or do you need something else?

@MatheusRich MatheusRich merged commit 688a808 into MatheusRich:main Oct 25, 2021
@MatheusRich
Copy link
Owner

Thank you @m3xq! Good work!

@m3xq m3xq deleted the add-config branch October 25, 2021 20:00
@MatheusRich MatheusRich mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatheusRich MatheusRich MatheusRich left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m3xq @MatheusRich