Corrected Sotuyo's mistakes checklist #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibarsin
force-pushed
the
newSotuyoFixes
branch
from
cfc6e08
to
f8c65e6
Compare
- Removed unnecesary commented code (tests, services, daos) - Spring Security only ignores the favicon resource - Removed Result class completely - Checked null for empty lists and int returning instead of Integer - Reformated and cleaned code - Removed unused files (JSP, static, Javascript)
gibarsin
force-pushed
the
newSotuyoFixes
branch
from
f8c65e6
to
753c274
Compare
Merged
MatiasComercio
pushed a commit
that referenced
this pull request
Feb 5, 2017
Corrected Sotuyo's mistakes checklist - Removed unnecesary commented code (tests, services, daos) - Spring Security only ignores the favicon resource - Removed Result class completely - Checked null for empty lists and int returning instead of Integer - Reformated and cleaned code - Removed unused files (JSP, static, Javascript) - Remove loop in getCorrelativeCoursesByFilter and rename getCorrelativeCourses - Add transactional to userExists method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trello Card
https://trello.com/c/0nPldvmP/110-correcciones-sotuyo