General Fixes #117
Merged
General Fixes #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Spring Security filter for VIEW_COURSE_FINAL_INSCRIPTIONS, VIEW_STUDENTS_APPROVED and VIEW_COURSE_STUDENT authorities
- To qualify a final for a student, the user must be have ADMIN authority
- Fix admin / student creation endpoints to support address
- Fix case where a student is tried to be created with an admin's dni or viceversa (the check was being made only for the corresponding Role and not for users in general)
- Return 409 CONFLICT and return a JSON with conflictField when trying to update a course's information (courseId or semester fields)
- Return 409 CONFLICT when trying to change password and the old password does not match the one in the database
- Return 404 NOT FOUND in case the user does not exist when resetting or changing password
- Changed permissions to change other user's password
- Restrict student access for GET /students/{docket} to itself and to admins
…ocation header only if the courseId is changed, else return 204 No content
Merged
MatiasComercio
pushed a commit
that referenced
this pull request
Feb 5, 2017
- Remove Spring Security filter for VIEW_COURSE_FINAL_INSCRIPTIONS, VIEW_STUDENTS_APPROVED and VIEW_COURSE_STUDENT authorities
- To qualify a final for a student, the user must be have ADMIN authority
- Fix admin / student creation endpoints to support address
- Fix case where a student is tried to be created with an admin's dni or viceversa (the check was being made only for the corresponding Role and not for users in general)
- Return 409 CONFLICT and return a JSON with conflictField when trying to update a course's information (courseId or semester fields)
- Return 409 CONFLICT when trying to change password and the old password does not match the one in the database
- Return 404 NOT FOUND in case the user does not exist when resetting or changing password
- Changed permissions to change other user's password
- Restrict student access for GET /students/{docket} to itself and to admins
- Allow updating information with the same courseId and returning the Location header only if the courseId is changed, else return 204 No content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trello Card
https://trello.com/c/5EeWCpcl/116-general-fixes