Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jersey #48

Merged
merged 62 commits into from
Jan 19, 2017
Merged

Jersey #48

merged 62 commits into from
Jan 19, 2017

Conversation

MatiasMercado
Copy link
Collaborator

APIRestful.

Migrated to Jersey Course Controller and Student Controller.

Student's final inscriptions are currently not working.

gibarsin and others added 30 commits January 5, 2017 20:48
java.lang.NoSuchMethodError: org.hibernate.internal.CoreMessageLogger.debugf
…Methods commented in OldStudentController have been migrated to UserController, except for maybe forms or Spring Security permissions.
…matchException and ValidationException.

 TODO: Return JSON instead of PLAIN_TEXT and use internationalization instead of harcoded strings for messages.
…O had to be changed to arrange properly their obligations.
# Conflicts:
#	webapp/src/main/java/ar/edu/itba/paw/webapp/controllers/DTOEntityMapper.java
#	webapp/src/main/java/ar/edu/itba/paw/webapp/controllers/StudentController.java
Conflicts:
	webapp/src/main/java/ar/edu/itba/paw/webapp/controllers/StudentController.java
…te is throwing an hibernate exception.

- Changed updateStudent to receive old student as not to do the getStudent query 2 times.
- TODO:
Check that updateStudent is not deleting other relations like studentGrades
Check updating the DNI for a student does not raise an exception in Address table (as DNI is a FK)
…was that the new address was being assigned to the student and then it was trying to get the id_seq from the address of the student (assuming it was the old address), so the original id_seq was not copied, hence the duplicate address for same DNI
…removing unnecessary assignments or return values. editAddress() function was changed from Student to docket because it should be independent whether a call was previously made to get the student.
gibarsin and others added 21 commits January 15, 2017 14:15
…rsesCorrelativesDestroy && add coursesFinalInscriptionQualify
# Conflicts:
#	services/src/main/java/ar/edu/itba/paw/services/StudentServiceImpl.java
#	webapp/src/main/java/ar/edu/itba/paw/webapp/controllers/DTOEntityMapper.java
#	webapp/src/main/java/ar/edu/itba/paw/webapp/models/GradeDTO.java
…sDestroy - [WORKING] add coursesFinalInscriptionsShow
[NW] Add studentFinalInscriptions methods but exceptions are thrown as no finalInstance table is empty in the DB
Conflicts:
	webapp/src/main/java/ar/edu/itba/paw/webapp/controllers/DTOEntityMapper.java
# Conflicts:
#	pom.xml
#	webapp/pom.xml
@codecov-io
Copy link

codecov-io commented Jan 19, 2017

Current coverage is 0.18% (diff: 0.00%)

No coverage report found for development at a0947b2.

Powered by Codecov. Last update a0947b2...b4c15d0

@gibarsin gibarsin merged commit 9e8325e into development Jan 19, 2017
@gibarsin gibarsin deleted the jersey branch January 19, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants